Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated Array from attribute package #2235

Merged
merged 5 commits into from Sep 10, 2021
Merged

Remove deprecated Array from attribute package #2235

merged 5 commits into from Sep 10, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 9, 2021

Resolve #2232

@MrAlias MrAlias added this to In progress in OpenTelemetry Go 1.0.0 via automation Sep 9, 2021
OpenTelemetry Go 1.0.0 automation moved this from In progress to Reviewer approved Sep 9, 2021
@Aneurysm9 Aneurysm9 merged commit ef126f5 into open-telemetry:main Sep 10, 2021
OpenTelemetry Go 1.0.0 automation moved this from Reviewer approved to Done Sep 10, 2021
@MrAlias MrAlias mentioned this pull request Sep 20, 2021
Merged
@slnt
Copy link

slnt commented Nov 1, 2021 •
edited

Why was Any removed? 🤔 Any seems to have no relation to array functions? It is still a useful function as a fallback when type is unknown.

@open-telemetry open-telemetry locked as resolved and limited conversation to collaborators Nov 1, 2021
@MrAlias MrAlias deleted the rm-dep-attr branch November 1, 2021 21:01
@MrAlias
Copy link
Contributor Author

MrAlias commented Nov 1, 2021

Why was Any removed? thinking Any seems to have no relation to array functions? It is still a useful function as a fallback when type is unknown.

@slnt Please open a new issue or discussion if you would like to have a conversation about the topic.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@jmacd jmacd jmacd approved these changes

@XSAM XSAM XSAM approved these changes

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
OpenTelemetry Go 1.0.0
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the deprecated attribute Array functions and methods
5 participants
@MrAlias @slnt @Aneurysm9 @jmacd @XSAM