Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding NewNoopMeterProvider to follow trace api #2237

Conversation

codeboten
Copy link
Contributor

The trace API provides the NewNoopTracerProvider method to return a noopTracerProvider. This PR adds the method NewNoopMeterProvider in the metric API. This is also making NoopTracerProvider private.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #2237 (0424216) into main (c338a5e) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2237   +/-   ##
=====================================
  Coverage   72.4%   72.4%           
=====================================
  Files        168     168           
  Lines      11764   11766    +2     
=====================================
+ Hits        8526    8530    +4     
+ Misses      3003    3001    -2     
  Partials     235     235           
Impacted Files Coverage Δ
metric/noop.go 30.7% <100.0%> (ø)

CHANGELOG.md Outdated Show resolved Hide resolved
@codeboten codeboten force-pushed the codeboten/add-newnoopmeterprovider-method branch from 567383c to fc3f099 Compare September 10, 2021 16:20
alrex and others added 2 commits September 10, 2021 09:21
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
@MrAlias MrAlias merged commit fe7058d into open-telemetry:main Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants