Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Schema URL when exporting traces to OTLP #2242

Merged

Conversation

tigrannajaryan
Copy link
Member

We previously were recording the Schema URL but were not setting
the recorded value when exporting. This change now uses the recorded
value when exporting to OTLP.

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #2242 (884c2d7) into main (ec26b55) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2242   +/-   ##
=====================================
  Coverage   72.4%   72.5%           
=====================================
  Files        168     168           
  Lines      11766   11768    +2     
=====================================
+ Hits        8530    8532    +2     
  Misses      3001    3001           
  Partials     235     235           
Impacted Files Coverage Δ
...ers/otlp/otlptrace/internal/tracetransform/span.go 96.7% <100.0%> (+<0.1%) ⬆️

@tigrannajaryan
Copy link
Member Author

@Aneurysm9 @MrAlias This does not change anything in the API, but it changes OTLP exporter behavior. Do we need a CHANGELOG entry for this?

@Aneurysm9
Copy link
Member

I think a changelog entry for this would be good as it can allow people to discover when a capability was added.

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; also note #2197 plumbs the instrumentation library schema through to the OTLP exporter for metrics, so that its schema URL can be set in the corresponding message.

We previously were recording the Schema URL but were not setting
the recorded value when exporting. This change now uses the recorded
value when exporting to OTLP.
@tigrannajaryan
Copy link
Member Author

Changelog entry added.

@tigrannajaryan
Copy link
Member Author

I think this is ready to be merged.

@Aneurysm9 Aneurysm9 merged commit 568e755 into open-telemetry:main Sep 16, 2021
@MrAlias MrAlias mentioned this pull request Sep 20, 2021
@tigrannajaryan tigrannajaryan deleted the export-schemaurl-to-traces branch May 2, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants