Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipkin: remove no-op WithSDKOptions #2248

Merged
merged 1 commit into from Sep 20, 2021

Conversation

andreimatei
Copy link
Contributor

This method did not have any effect. had been used back
when exporters were providing utility methods for setting up full
pipelines. These utilities went away in
4883cb1.

This method did not have any effect. had been used back
when exporters were providing utility methods for setting up full
pipelines. These utilities went away in
4883cb1.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 19, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Can you sign the CLA?

Here are some hyperlinks which should help you:

@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #2248 (ca315c6) into main (568e755) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2248   +/-   ##
=====================================
  Coverage   72.4%   72.5%           
=====================================
  Files        168     168           
  Lines      11768   11764    -4     
=====================================
+ Hits        8530    8532    +2     
+ Misses      3003    2997    -6     
  Partials     235     235           
Impacted Files Coverage Δ
exporters/zipkin/zipkin.go 72.8% <ø> (+3.0%) ⬆️
exporters/jaeger/jaeger.go 94.3% <0.0%> (+0.8%) ⬆️

@pellared pellared added the blocked:CLA Waiting on CLA to be signed before progress can be made label Sep 19, 2021
@andreimatei
Copy link
Contributor Author

Can you sign the CLA?

Done

@pellared pellared removed the blocked:CLA Waiting on CLA to be signed before progress can be made label Sep 19, 2021
@MrAlias MrAlias merged commit 6183913 into open-telemetry:main Sep 20, 2021
@MrAlias MrAlias mentioned this pull request Sep 20, 2021
@andreimatei andreimatei deleted the zipkin-remove-unused branch September 20, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants