Metrics: Rename sdk/export/metric.ExportKind to aggregation.Temporality

[jmacd]

This is a re-do of #2272.
Part of #2273.

[codecov]

Codecov Report

Merging #2274 (790cf48) into main (e72a235) will increase coverage by 0.0%.
The diff coverage is 89.5%.

@@          Coverage Diff          @@
##            main   #2274   +/-   ##
=====================================
  Coverage   72.6%   72.6%           
=====================================
  Files        171     172    +1     
  Lines      11918   11918           
=====================================
+ Hits        8660    8663    +3     
+ Misses      3023    3021    -2     
+ Partials     235     234    -1     

Impacted Files	Coverage Δ
...tlp/otlpmetric/internal/otlpmetrictest/otlptest.go	0.0% <0.0%> (ø)
...dk/export/metric/aggregation/temporality_string.go	0.0% <0.0%> (ø)
sdk/export/metric/metric.go	0.0% <ø> (-44.7%)	⬇️
sdk/metric/controller/controllertest/test.go	100.0% <ø> (ø)
sdk/metric/processor/processortest/test.go	85.5% <85.7%> (ø)
sdk/export/metric/aggregation/temporality.go	96.1% <96.1%> (ø)
bridge/opencensus/exporter.go	100.0% <100.0%> (ø)
exporters/otlp/otlpmetric/exporter.go	60.6% <100.0%> (ø)
...otlp/otlpmetric/internal/metrictransform/metric.go	79.0% <100.0%> (ø)
exporters/otlp/otlpmetric/options.go	100.0% <100.0%> (ø)
... and 4 more

[MrAlias]

It looks like the stringer generation needs to be run again.

[jmacd]

Are we expected to manually insert the vanity import for generated files?

[jmacd]

make lint succeeds for me locally. Can anyone suggest a fix?

[MrAlias]

Are we expected to manually insert the vanity import for generated files?

I'm not that familiar with the vanity import tooling that was added, but that doesn't seem ideal. It seems like that is what was done in the PR that added that instrumentation -

opentelemetry-go/attribute/type_string.go

Line 3 in 7372752

package attribute // import "go.opentelemetry.io/otel/attribute"

[MrAlias]

It looks like the latest update of that tooling has a fix to skip generated files and dependabot just opened a PR for it #2288.

I'll plan to merge this first though given we have a manual fix.