Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip links with invalid span context #2275

Merged
merged 7 commits into from Oct 12, 2021

Conversation

srikanthccv
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #2275 (c0511ed) into main (c71afaf) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2275   +/-   ##
=====================================
  Coverage   72.4%   72.4%           
=====================================
  Files        168     168           
  Lines      11888   11888           
=====================================
+ Hits        8608    8614    +6     
+ Misses      3045    3041    -4     
+ Partials     235     233    -2     
Impacted Files Coverage Δ
trace/config.go 63.7% <ø> (ø)
sdk/trace/span.go 82.0% <100.0%> (+0.9%) ⬆️
...s/otlp/otlptrace/internal/connection/connection.go 16.2% <0.0%> (+1.5%) ⬆️

sdk/trace/tracer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include an update to the WithLinks documentation about the behavior for links with invalid SpanContext.

CHANGELOG.md Outdated Show resolved Hide resolved
sdk/trace/tracer.go Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 8ba6da8 into open-telemetry:main Oct 12, 2021
@srikanthccv srikanthccv deleted the link-context branch October 12, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants