Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semconv/v1.5.0 package #2322

Merged
merged 3 commits into from Oct 25, 2021
Merged

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 21, 2021

Generated from a modified version of the v1.5.0 release of the specification using a modified version of the semconvgen tools. The specification contained capitalized IDs that caused errors from the semconvgen tool. These errors were manually resolved and the rest of the Go formatting tools were used to provide consistent code. The changes were then double checked by looking at a diff in the specification and in the generated code between the v1.4.0 and v1.5.0 tags. All the changes made were valid.

Important to note, the Go semconvgen tooling includes new name capitalization rules for ReplicaSet, StatefulSet, and DaemonSet that mean code names are not backwards compatible. This is included in the changelog to help users perform the upgrade.

Generated from a modified version of the v1.5.0 release of the
specification using a modified version of the semconvgen tools. The
specification contained capitalized IDs that caused errors from the
semconvgen tool. These errors were manually resolved and the rest of the
Go formatting tools were used to provide consistent code.

Important to note, the Go semconvgen tooling includes new name
capitalization rules for ReplicaSet, StatefulSet, and DaemonSet that
mean code names are not backwards compatible. This is included in the
changelog to help users perform the upgrade.
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #2322 (7fb198f) into main (4c59cc4) will increase coverage by 0.3%.
The diff coverage is 96.3%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2322     +/-   ##
=======================================
+ Coverage   73.3%   73.6%   +0.3%     
=======================================
  Files        174     175      +1     
  Lines      12245   12409    +164     
=======================================
+ Hits        8976    9137    +161     
- Misses      3035    3039      +4     
+ Partials     234     233      -1     
Impacted Files Coverage Δ
semconv/v1.5.0/http.go 96.3% <96.3%> (ø)
...s/otlp/otlptrace/internal/connection/connection.go 16.2% <0.0%> (+1.5%) ⬆️

@tigrannajaryan
Copy link
Member

I assume this is done according to these instructions: https://github.com/open-telemetry/opentelemetry-go/blob/main/RELEASING.md#semantic-convention-generation

Do you also plan to repeat this for specs 1.6.1 and 1.7.0?

@tigrannajaryan
Copy link
Member

Do you also plan to repeat this for specs 1.6.1 and 1.7.0?

Nevermind, I see the PRs.

@Aneurysm9 Aneurysm9 merged commit 8324034 into open-telemetry:main Oct 25, 2021
@MrAlias MrAlias deleted the semconv-v1.5.0 branch October 25, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants