Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MapCarrier #2334

Merged
merged 7 commits into from Oct 29, 2021
Merged

Add MapCarrier #2334

merged 7 commits into from Oct 29, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 28, 2021

Adds a new MapCarrier type to the propagation package that holds propagated cross-cutting concerns in a map held in memory. This type is motivated by users common need to inject/extract propagated values using a simple, built-in, Go type. For instance, users can create a new MapCarrier with values from the environment and inject the trace context into a Go context.

Supersedes and closes #2245.

Fixes #2243.

@MrAlias MrAlias added enhancement New feature or request area:propagators Part of OpenTelemetry context propagation labels Oct 28, 2021
@MrAlias MrAlias mentioned this pull request Oct 28, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #2334 (709f532) into main (4ba964b) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2334     +/-   ##
=======================================
- Coverage   73.6%   73.6%   -0.1%     
=======================================
  Files        175     175             
  Lines      12409   12419     +10     
=======================================
  Hits        9144    9144             
- Misses      3034    3041      +7     
- Partials     231     234      +3     
Impacted Files Coverage Δ
propagation/propagation.go 85.7% <100.0%> (+4.4%) ⬆️
sdk/metric/refcount_mapped.go 80.0% <0.0%> (-20.0%) ⬇️
...s/otlp/otlptrace/internal/connection/connection.go 14.6% <0.0%> (-1.6%) ⬇️
sdk/metric/sdk.go 80.2% <0.0%> (-1.5%) ⬇️

@Aneurysm9 Aneurysm9 merged commit ef0cdeb into open-telemetry:main Oct 29, 2021
@MrAlias MrAlias deleted the str-map-carrier branch October 29, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:propagators Part of OpenTelemetry context propagation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider having a map and request header Carrier in SDK
3 participants