Remove metric aggregator Subtract interface #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
dashpole,
evantorrie,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2350 +/- ##
=====================================
Coverage 73.5% 73.5%
=====================================
Files 174 174
Lines 12298 12273 -25
=====================================
- Hits 9041 9026 -15
+ Misses 3017 3009 -8
+ Partials 240 238 -2
|
cbandy
reviewed
Nov 9, 2021
pirgeo
reviewed
Nov 10, 2021
|
LGTM, needs attention to get lint to pass. |
|
Looks like this needs a |
bogdandrutu
approved these changes
Nov 12, 2021
…o jmacd/remove_subtract2
Co-authored-by: Georg Pirklbauer <georg.pirklbauer@dynatrace.com>
…o jmacd/remove_subtract2
MrAlias
reviewed
Nov 15, 2021
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
…ry-go into jmacd/remove_subtract2
MrAlias
approved these changes
Nov 15, 2021
MrAlias
reviewed
Nov 15, 2021
Gahh, I spoke too soon. I forgot that @bogdandrutu is not in the @open-telemetry/go-approvers group. We need one more approval. |
MadVikingGod
approved these changes
Nov 15, 2021
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a bunch of complexity that the Metrics SIG group decided not to specify for the default SDK. The implication is that you will no longer be able to convert asynchronous counters into delta counters for export, which is no great loss.
Fixes #2349.