Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bound metric instruments from the API (new champion) #2399

Merged
merged 5 commits into from Nov 17, 2021

Conversation

MadVikingGod
Copy link
Contributor

@jmacd has become overloaded and asked me to take over #2352 . Because it needs a rebase and a few additions it's easier to start a new PR.

From the original PR:
This demonstrates how much code we can remove by eliminating bound instruments. I believe this is worthwhile and I would rather focus on optimizing the code path for extracting baggage and the performance of RecordBatch(), not individual bound instrument APIs.

Fixes #2351

Changes from #2353:

  • Rebased to main to fix a number of lint errors not related to this change
  • Added changelog note
  • Removed the dead code

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #2399 (cfce36c) into main (b663c7c) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2399     +/-   ##
=======================================
- Coverage   73.5%   73.3%   -0.2%     
=======================================
  Files        174     174             
  Lines      12273   12187     -86     
=======================================
- Hits        9021    8942     -79     
+ Misses      3013    3007      -6     
+ Partials     239     238      -1     
Impacted Files Coverage Δ
internal/metric/global/meter.go 89.3% <ø> (-0.5%) ⬇️
metric/metric_instrument.go 89.1% <ø> (-1.4%) ⬇️
metric/metrictest/meter.go 94.4% <ø> (-1.8%) ⬇️
metric/sdkapi/noop.go 88.8% <ø> (+27.3%) ⬆️
metric/sdkapi/sdkapi.go 100.0% <ø> (ø)
sdk/metric/sdk.go 80.0% <100.0%> (-0.2%) ⬇️

@MrAlias MrAlias merged commit 0349561 into open-telemetry:main Nov 17, 2021
@Aneurysm9 Aneurysm9 mentioned this pull request Dec 10, 2021
@MadVikingGod MadVikingGod deleted the jmacd/remove_bound branch February 21, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing bound metric instrument support
5 participants