Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger span status translation incorrect #2439

Closed
MrAlias opened this issue Dec 9, 2021 · 1 comment · Fixed by #2440
Closed

Jaeger span status translation incorrect #2439

MrAlias opened this issue Dec 9, 2021 · 1 comment · Fixed by #2440
Assignees
Labels
bug Something isn't working
Projects

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Dec 9, 2021

Description

The Jaeger exporter translates a span status to an integer tag.

tags = append(tags, getInt64Tag(keyStatusCode, int64(ss.Status().Code)))

The OpenTelemetry specification states this should be a string tag with the value of OK or ERROR.

This can cause error spans to be translated to OK in the collector: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/3de607f6cd38673924397f8a3c9158d89b491207/pkg/translator/jaeger/jaegerproto_to_traces.go#L211-L233

The error tag is cleared and since our Error code is the pdata.StatusOk value the span ultimately will not be counted as an error (there are also errors in the collector receiver based on this).

@MrAlias MrAlias added the bug Something isn't working label Dec 9, 2021
@MrAlias MrAlias self-assigned this Dec 9, 2021
@MrAlias MrAlias added this to Needs triage in Bugs via automation Dec 9, 2021
@MrAlias MrAlias moved this from Needs triage to High priority in Bugs Dec 9, 2021
@MadVikingGod
Copy link
Contributor

MadVikingGod commented Dec 9, 2021

Just a heads up from after our conversation in the SIG meeting. We were planning to release about 20 hours from this being posted. Seeing as we have multiple approvals, and it is a bug I can understand allowing us to merge sooner, but I would like to point out that we are doing so.

Bugs automation moved this from High priority to Closed Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Bugs
  
Closed
Development

Successfully merging a pull request may close this issue.

2 participants