Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jaeger exporter status conversion #2440

Merged
merged 2 commits into from Dec 10, 2021

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 9, 2021

The status tag needs to be a string of value ERROR or OK for Error and Ok statuses respectively according to the OTel spec.

Resolve #2439

The status tag needs to be a string of value `ERROR` or `OK` for Error
and Ok statuses respectively according to the OTel spec.
@MrAlias MrAlias added the pkg:exporter:jaeger Related to the Jaeger exporter package label Dec 9, 2021
@MrAlias MrAlias added the bug Something isn't working label Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #2440 (c4e2a8a) into main (9312664) will increase coverage by 0.0%.
The diff coverage is 66.6%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2440   +/-   ##
=====================================
  Coverage   76.0%   76.0%           
=====================================
  Files        173     173           
  Lines      12008   12010    +2     
=====================================
+ Hits        9130    9134    +4     
+ Misses      2633    2631    -2     
  Partials     245     245           
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 93.5% <66.6%> (+<0.1%) ⬆️
sdk/trace/batch_span_processor.go 85.4% <0.0%> (+1.0%) ⬆️

@Aneurysm9 Aneurysm9 merged commit b46019a into open-telemetry:main Dec 10, 2021
@Aneurysm9
Copy link
Member

Merged prior to 24h elapsed as this has consensus approval and should be included in the release currently being prepared.

@MrAlias MrAlias mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg:exporter:jaeger Related to the Jaeger exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger span status translation incorrect
5 participants