Fixes the instrument kind for noop async instruments

[bogdandrutu]

Fixes #2460

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

[codecov]

Codecov Report

Merging #2461 (8ea2bec) into main (49987ad) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main   #2461   +/-   ##
=====================================
  Coverage   76.3%   76.3%           
=====================================
  Files        173     173           
  Lines      12010   12022   +12     
=====================================
+ Hits        9167    9179   +12     
  Misses      2598    2598           
  Partials     245     245           

Impacted Files	Coverage Δ
metric/sdkapi/noop.go	95.2% <100.0%> (+6.3%)	⬆️

[MadVikingGod]

I have a fundamental disagreement on the underlying problem that the test exposes. Put simply, we assume that if descriptor.Name(), descriptor.InstrumentKind() and descriptor.NumberKind() all match, then the Instrument stored in the map MUST be the same type.

The solution to this should then be either:

• We check that the types match, so we don't panic.
• We do something to separate the Sync from the Async so that we don't need to check.

This way if this registry is ever used again we don't find ourselves retreading this.

[bogdandrutu]

@MadVikingGod no test anymore, this is still a bug fix so please prioritize.