Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Histogram mapping functions for public use #2502

Merged
merged 10 commits into from Mar 22, 2022

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jan 7, 2022

As proposed in #2501 when closing #2393 (for later), this introduces public packages in sdk/metric/aggregator/exponential/mapping. This is a first step for adding exponential histogram support in OTel-Go as well as the OTel-Collector. (See for example open-telemetry/opentelemetry-collector#4642 and open-telemetry/opentelemetry-collector-contrib#6666).

Follows the specification in open-telemetry/opentelemetry-specification#2252

Fixes #2501

Factored apart from #2393

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #2502 (920f961) into main (8a7dcd9) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2502     +/-   ##
=======================================
+ Coverage   76.5%   76.7%   +0.1%     
=======================================
  Files        178     181      +3     
  Lines      12072   12175    +103     
=======================================
+ Hits        9242    9345    +103     
  Misses      2605    2605             
  Partials     225     225             
Impacted Files Coverage Δ
...ggregator/exponential/mapping/exponent/exponent.go 100.0% <100.0%> (ø)
...aggregator/exponential/mapping/exponent/float64.go 100.0% <100.0%> (ø)
...regator/exponential/mapping/logarithm/logarithm.go 100.0% <100.0%> (ø)

👍

Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
@Aneurysm9 Aneurysm9 added this to the Metrics API for 1.0 milestone Feb 2, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 07ad32d into open-telemetry:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose public exponential histogram mapping functions
4 participants