Export resource attributes from zipkin exporter #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tttanikawa
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
|
|
Aneurysm9
reviewed
Feb 8, 2022
MrAlias
reviewed
Feb 8, 2022
There was a problem hiding this comment.
Thanks for the contribution. I think the approach to add tags looks good. Please unify the attribute conversion like @Aneurysm9 suggested.
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
|
Thank you for the review. |
Aneurysm9
approved these changes
Feb 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #2589 +/- ##
=====================================
Coverage 76.2% 76.2%
=====================================
Files 173 173
Lines 12229 12238 +9
=====================================
+ Hits 9319 9328 +9
Misses 2667 2667
Partials 243 243
|
pellared
approved these changes
Feb 9, 2022
MrAlias
approved these changes
Feb 9, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2588
This PR enables the zipkin exporter to export
Resourceattributes asTags.I modified some test cases to check
Resourceattributes to be exported, and all tests passed.