Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env support for span limits configuration #2606

Merged
merged 12 commits into from Feb 17, 2022

Conversation

cuichenli
Copy link
Contributor

Closes #2307

@cuichenli cuichenli changed the title Add env support for otel_span configuration Add env support for span limits configuration Feb 14, 2022
@cuichenli cuichenli marked this pull request as ready for review February 14, 2022 03:09
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #2606 (a93622c) into main (b675dda) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2606   +/-   ##
=====================================
  Coverage   76.2%   76.2%           
=====================================
  Files        173     173           
  Lines      12234   12239    +5     
=====================================
+ Hits        9324    9329    +5     
  Misses      2667    2667           
  Partials     243     243           
Impacted Files Coverage Δ
sdk/internal/env/env.go 100.0% <ø> (ø)
sdk/trace/config.go 100.0% <100.0%> (ø)
sdk/trace/provider.go 82.5% <100.0%> (+<0.1%) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
sdk/trace/provider.go Outdated Show resolved Hide resolved
sdk/trace/provider_test.go Show resolved Hide resolved
@cuichenli
Copy link
Contributor Author

Hi @Aneurysm9 , I have updated the code based on the above comments. Please take a look again. Thanks!

CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
sdk/trace/provider.go Outdated Show resolved Hide resolved
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
sdk/trace/provider_test.go Outdated Show resolved Hide resolved
cuichenli and others added 2 commits February 17, 2022 09:43
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias merged commit 98c2c9d into open-telemetry:main Feb 17, 2022
@MrAlias MrAlias added this to the Release v1.5.0 milestone Feb 24, 2022
@MrAlias MrAlias mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the OTEL_SPAN_* environment variables
6 participants