Fix race condition in reading the dropped spans number #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod and
pellared
as code owners
As any race condition this should be consider an undefined behavior, and a patch release should be done. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
rmracecondition
branch
from
ac6561a
to
fb82c93
Compare
Codecov Report
@@ Coverage Diff @@
## main #2615 +/- ##
=====================================
Coverage 76.2% 76.2%
=====================================
Files 173 173
Lines 12238 12238
=====================================
Hits 9328 9328
Misses 2667 2667
Partials 243 243
|
MrAlias
reviewed
Feb 16, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
pellared
approved these changes
Feb 16, 2022
XSAM
approved these changes
Feb 16, 2022
MadVikingGod
approved these changes
Feb 16, 2022
|
Since this is an important bug fix, can you please merge and release 1.4.1. This blocks downstream dependencies to upgrade, since tools will block the upgrade because of race condition detected. |
|
Working on the release now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As any race condition this should be consider an undefined behavior, and a patch release should be done.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com