Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify OTLP path parsing/default Logic #2639

Merged
merged 24 commits into from Mar 2, 2022

Conversation

hanyuancheung
Copy link
Member

Fix #2634 and #2625 (comment)

  • Unify of path parsing/default functionally.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #2639 (9d6cb63) into main (79f6bc1) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2639   +/-   ##
=====================================
  Coverage   76.0%   76.0%           
=====================================
  Files        173     174    +1     
  Lines      12293   12286    -7     
=====================================
- Hits        9344    9341    -3     
  Misses      2702    2702           
+ Partials     247     243    -4     
Impacted Files Coverage Δ
exporters/otlp/internal/config.go 100.0% <100.0%> (ø)
...ers/otlp/otlpmetric/internal/otlpconfig/options.go 81.3% <100.0%> (+1.1%) ⬆️
...ters/otlp/otlptrace/internal/otlpconfig/options.go 81.3% <100.0%> (+1.1%) ⬆️
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️

exporters/otlp/internal/config.go Outdated Show resolved Hide resolved
exporters/otlp/internal/config.go Outdated Show resolved Hide resolved
exporters/otlp/internal/config.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
exporters/otlp/internal/config_test.go Outdated Show resolved Hide resolved
exporters/otlp/internal/config_test.go Show resolved Hide resolved
hanyuancheung and others added 7 commits February 25, 2022 11:17
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@hanyuancheung
Copy link
Member Author

PTLA.

exporters/otlp/internal/config_test.go Outdated Show resolved Hide resolved
exporters/otlp/internal/config_test.go Outdated Show resolved Hide resolved
exporters/otlp/internal/config_test.go Outdated Show resolved Hide resolved
exporters/otlp/internal/config_test.go Outdated Show resolved Hide resolved
exporters/otlp/internal/config.go Outdated Show resolved Hide resolved
exporters/otlp/internal/config.go Outdated Show resolved Hide resolved
hanyuancheung and others added 7 commits March 2, 2022 18:39
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
Co-authored-by: Sam Xie <sam@samxie.me>
@MrAlias MrAlias merged commit b66c902 into open-telemetry:main Mar 2, 2022
hanyuancheung added a commit to hanyuancheung/opentelemetry-go that referenced this pull request Mar 5, 2022
* unify otlp path parsing/default logic

* add changelog

* add license and unit test

* remove else branch

* increase unitt test coverage

* add vanity import

* Update exporters/otlp/internal/config.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update exporters/otlp/internal/config.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update exporters/otlp/internal/config.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update exporters/otlp/internal/config_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* Update exporters/otlp/internal/config_test.go

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

* format the config_test.go

* Update exporters/otlp/internal/config_test.go

Co-authored-by: Sam Xie <sam@samxie.me>

* Update exporters/otlp/internal/config_test.go

Co-authored-by: Sam Xie <sam@samxie.me>

* Update exporters/otlp/internal/config_test.go

Co-authored-by: Sam Xie <sam@samxie.me>

* Update exporters/otlp/internal/config_test.go

Co-authored-by: Sam Xie <sam@samxie.me>

* Update exporters/otlp/internal/config.go

Co-authored-by: Sam Xie <sam@samxie.me>

* Update exporters/otlp/internal/config.go

Co-authored-by: Sam Xie <sam@samxie.me>

* change URLPath to urlPath

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Sam Xie <sam@samxie.me>
@MrAlias MrAlias mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify OTLP path parsing/default logic
3 participants