Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BatchSpanProcessor debug message #2640

Merged
merged 3 commits into from Feb 25, 2022

Conversation

MadVikingGod
Copy link
Contributor

Closes: #2620

This changes the debug message attribute to better reflect its cumulative nature.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #2640 (0f005f4) into main (a15269a) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2640   +/-   ##
=====================================
  Coverage   76.2%   76.2%           
=====================================
  Files        173     173           
  Lines      12253   12253           
=====================================
+ Hits        9342    9345    +3     
+ Misses      2664    2663    -1     
+ Partials     247     245    -2     
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 80.2% <100.0%> (-1.9%) ⬇️
sdk/metric/sdk.go 81.5% <0.0%> (+1.4%) ⬆️
sdk/metric/refcount_mapped.go 100.0% <0.0%> (+20.0%) ⬆️

Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MrAlias MrAlias added this to the Release v1.5.0 milestone Feb 24, 2022
@MrAlias MrAlias merged commit 8eb3766 into open-telemetry:main Feb 25, 2022
@MadVikingGod MadVikingGod deleted the total_dropped branch February 25, 2022 16:43
@MrAlias MrAlias mentioned this pull request Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch temporality in BatchSpanProcessor Debug message
5 participants