Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor out the duplicated code in OTLP exporter #2641

Closed
hanyuancheung opened this issue Feb 27, 2022 · 5 comments
Closed

Refactor out the duplicated code in OTLP exporter #2641

hanyuancheung opened this issue Feb 27, 2022 · 5 comments
Assignees
@hanyuancheung
Labels
enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package

Comments

@hanyuancheung
Copy link
Member

hanyuancheung commented Feb 27, 2022 •
edited

Problem Statement

Code in exporter/otlp/otlpmetric(otlptrace)/internal/ are duplicated. Since the Metrics spec has been stable, as well as the Metrics API/SDK are going to be stable, we should refactor these duplicated codes.

Proposed Solution

Refactor (transform, connection, otlpconfig) in exporter/otlp/otlpmetric(otlptrace)/internal/, move to exporter/otlp/internal/*.

Alternatives

Maybe do this after Metrics implementation is stable.
@hanyuancheung hanyuancheung added enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package labels Feb 27, 2022
@hanyuancheung hanyuancheung self-assigned this Feb 27, 2022
@dmathieu
Copy link
Member

dmathieu commented Mar 1, 2022

Note: I've started doing that with environment variables in #2608.

@hanyuancheung
Copy link
Member Author

hanyuancheung commented Mar 1, 2022 •
edited

Note: I've started doing that with environment variables in #2608.

I get it. After this PR is merged, I'll finish the other parts.

@MrAlias
Copy link
Contributor

MrAlias commented Mar 18, 2022

#2608 has been merged.

@hanyuancheung
Copy link
Member Author

#2608 has been merged.

Yeah, I‘ve started working on this.

This was referenced Mar 19, 2022
Closed
Closed
@hanyuancheung hanyuancheung mentioned this issue Apr 21, 2022
Closed
6 tasks
@hanyuancheung hanyuancheung mentioned this issue Sep 18, 2022
Closed
1 task
@MrAlias
Copy link
Contributor

MrAlias commented Sep 14, 2023

Closed with #4420

@MrAlias MrAlias closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hanyuancheung hanyuancheung

Labels
enhancement New feature or request pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmathieu @MrAlias @hanyuancheung