Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT and OTEL_ATTRIBUTE_COUNT_LIMIT #2675

Closed
MrAlias opened this issue Mar 15, 2022 · 0 comments · Fixed by #2677
Closed

Support OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT and OTEL_ATTRIBUTE_COUNT_LIMIT #2675

MrAlias opened this issue Mar 15, 2022 · 0 comments · Fixed by #2677
Assignees
Labels
pkg:SDK Related to an SDK package

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 15, 2022

Description

Currently the SDK supports the OTEL_SPAN_ATTRIBUTE_VALUE_LENGTH_LIMIT, but not OTEL_ATTRIBUTE_VALUE_LENGTH_LIMIT. Similarly OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT is supported, but OTEL_ATTRIBUTE_COUNT_LIMIT is not.

Precedence needs to follow the specification:

An SDK MAY implement model-specific limits, for example SpanAttributeCountLimit. If both a general and a model-specific limit are implemented, then the SDK MUST first attempt to use the model-specific limit, if it isn't set, then the SDK MUST attempt to use the general limit. If neither are defined, then the SDK MUST try to use the model-specific limit default value, followed by the global limit default value.

@MrAlias MrAlias added the pkg:SDK Related to an SDK package label Mar 15, 2022
@MrAlias MrAlias self-assigned this Mar 15, 2022
@MrAlias MrAlias added this to the Release v1.6.0 milestone Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:SDK Related to an SDK package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant