Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix schema URLs #2744

Merged
merged 3 commits into from Mar 28, 2022
Merged

Fix schema URLs #2744

merged 3 commits into from Mar 28, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 28, 2022

Resolve #2743

@MrAlias MrAlias added the bug Something isn't working label Mar 28, 2022
@MrAlias MrAlias added this to the Release v1.6.1 milestone Mar 28, 2022
XSAM
XSAM approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@XSAM XSAM left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, should we update CHANGELOG?

@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 28, 2022

lgtm, should we update CHANGELOG?

Yeah, let me update.

tigrannajaryan
tigrannajaryan approved these changes Mar 28, 2022
View reviewed changes
semconv/v1.4.0/schema.go Show resolved Hide resolved
@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 28, 2022

Merging prior to the 1 working day policy due to the large number of approvals and our desire to include this in the release that is going out today.

@MrAlias MrAlias merged commit 1f8ad00 into open-telemetry:main Mar 28, 2022
@MrAlias MrAlias deleted the fix-schema-url branch March 28, 2022 16:23
@MrAlias MrAlias mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@pellared pellared pellared approved these changes

@XSAM XSAM XSAM approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@paivagustavo paivagustavo Awaiting requested review from paivagustavo

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Release v1.6.1
Development

Successfully merging this pull request may close these issues.

Schema URL constants do not resolve
6 participants
@MrAlias @Aneurysm9 @MadVikingGod @tigrannajaryan @pellared @XSAM