Don't panic when setting a provider to itself #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2749 +/- ##
=====================================
Coverage 76.7% 76.8%
=====================================
Files 181 181
Lines 12178 12189 +11
=====================================
+ Hits 9352 9367 +15
+ Misses 2601 2597 -4
Partials 225 225
|
XSAM
reviewed
Mar 29, 2022
pellared
reviewed
Mar 29, 2022
|
The CI test failure seems unrelated (I can't restart it though). |
pellared
reviewed
Mar 30, 2022
pellared
reviewed
Mar 30, 2022
pellared
approved these changes
Mar 30, 2022
XSAM
approved these changes
Mar 30, 2022
MrAlias
reviewed
Mar 30, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
MrAlias
approved these changes
Mar 31, 2022
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2682
This avoids panicking when setting a TracerProvider, MeterProvider or TextMapPropagator to itself, but returns early instead, so a noop happens.
While doing this, I also added better tests for the trace state, so they align with metrics tests.