Add User-Agent header to OTLP exporter requests #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerogers
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
rogerogers
force-pushed
the
feature/exporter-user-agent
branch
from
c0aad6b
to
f0d79dd
Compare
Signed-off-by: rogerogers <rogers@rogerogers.com>
rogerogers
force-pushed
the
feature/exporter-user-agent
branch
from
f0d79dd
to
0d7ab2c
Compare
dmathieu
requested changes
Oct 6, 2022
Signed-off-by: rogerogers <rogers@rogerogers.com>
dmathieu
approved these changes
Oct 7, 2022
|
Sorry, I meant to remove my red blocker and GitHub thought that meant I approved the PR 🤦 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3261 +/- ##
=====================================
Coverage 77.3% 77.4%
=====================================
Files 159 160 +1
Lines 11182 11200 +18
=====================================
+ Hits 8647 8671 +24
+ Misses 2337 2330 -7
- Partials 198 199 +1
|
dmathieu
reviewed
Oct 7, 2022
Signed-off-by: rogerogers <rogers@rogerogers.com>
Signed-off-by: rogerogers <rogers@rogerogers.com>
dmathieu
approved these changes
Oct 7, 2022
Aneurysm9
approved these changes
Oct 7, 2022
hanyuancheung
approved these changes
Oct 11, 2022
dashpole
pushed a commit
to dashpole/opentelemetry-go
that referenced
this pull request
Oct 11, 2022
* Add User-Agent header to OTLP exporter requests * allow override grpc user-agent Signed-off-by: rogerogers <rogers@rogerogers.com>
Merged
This was referenced Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rogerogers rogers@rogerogers.com
Implements spec open-telemetry/opentelemetry-specification#2684
#3258