Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the sdk/metric/view package #3476

Merged
merged 3 commits into from Nov 21, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 19, 2022

Step 4 of 4 from #3399

Resolves #3399

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Nov 19, 2022
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Nov 19, 2022
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #3476 (96148e6) into main (dbf960c) will decrease coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3476     +/-   ##
=======================================
- Coverage   77.8%   77.8%   -0.1%     
=======================================
  Files        165     165             
  Lines      11614   11614             
=======================================
- Hits        9046    9044      -2     
- Misses      2372    2374      +2     
  Partials     196     196             
Impacted Files Coverage Δ
sdk/metric/view/view.go 97.2% <ø> (ø)
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️

@MrAlias MrAlias merged commit c4333a9 into open-telemetry:main Nov 21, 2022
@MrAlias MrAlias deleted the view-deprecation branch November 21, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Replace the view implementation in the metric SDK
3 participants