Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add funcs to semconv to create semantic convention KeyValues #3675

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 3, 2023

Currently the semconv packages provide attribute keys users can use to build key-values from, but the key-value type is also a part of the semantic convention. Instead of requiring a user to get this type correct, provide creation functions for each semantic convention that is not explicitly restricted to be an enum.

Changes

  • Update the semconv template to generate creation functions for semconv keys that are not explicitly defined as enums
  • Clean documentation
    • Wrap > 79 characters
    • Do not split on hyphens or long words
    • Follow Go documentation guidelines by starting with the object name
  • Re-generate v1.17.0 with new generation template

@MrAlias MrAlias changed the title Add functions to generate semantic convention KeyValues Add funcs to semconv to create semantic convention KeyValues Feb 3, 2023
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #3675 (b7a4621) into main (d3986ef) will decrease coverage by 0.1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3675     +/-   ##
=======================================
- Coverage   79.7%   79.7%   -0.1%     
=======================================
  Files        171     171             
  Lines      12673   12673             
=======================================
- Hits       10103   10101      -2     
- Misses      2357    2359      +2     
  Partials     213     213             
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-0.9%) ⬇️

@MrAlias MrAlias merged commit 0446207 into open-telemetry:main Feb 6, 2023
@MrAlias MrAlias deleted the semconv-funcs branch February 6, 2023 17:41
@MrAlias MrAlias added this to the Release v1.13.0 milestone Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants