Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove http.target attr from ServerRequest #3687

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Feb 7, 2023

Removed the http.target attribute from being added by the ServerRequest function in httpconv packages.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #3687 (598687f) into main (0446207) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3687   +/-   ##
=====================================
  Coverage   79.7%   79.7%           
=====================================
  Files        171     171           
  Lines      12673   12673           
=====================================
  Hits       10105   10105           
  Misses      2355    2355           
  Partials     213     213           
Impacted Files Coverage Δ
semconv/internal/v2/http.go 100.0% <100.0%> (ø)

@Aneurysm9 Aneurysm9 merged commit 7b74959 into open-telemetry:main Feb 7, 2023
@MrAlias MrAlias deleted the rm-http-target-attr branch February 7, 2023 19:12
@MrAlias MrAlias added this to the Release v1.13.0 milestone Feb 8, 2023
@MrAlias MrAlias added the bug Something isn't working label Feb 8, 2023
@MrAlias MrAlias mentioned this pull request Mar 1, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants