The otel package implicitly requires Go >= 1.18

[MrAlias]

opentelemetry-go/internal/attribute/attribute.go

Lines 25 to 45 in 441a173

	// SliceValue convert a slice into an array with same elements as slice.
	func SliceValue[T bool | int64 | float64 | string](v []T) any {
	var zero T
	cp := reflect.New(reflect.ArrayOf(len(v), reflect.TypeOf(zero)))
	copy(cp.Elem().Slice(0, len(v)).Interface().([]T), v)
	return cp.Elem().Interface()
	}
	// AsSlice convert an array into a slice into with same elements as array.
	func AsSlice[T bool | int64 | float64 | string](v any) []T {
	rv := reflect.ValueOf(v)
	if rv.Type().Kind() != reflect.Array {
	return nil
	}
	var zero T
	correctLen := rv.Len()
	correctType := reflect.ArrayOf(correctLen, reflect.TypeOf(zero))
	cpy := reflect.New(correctType)
	_ = reflect.Copy(cpy.Elem(), rv)
	return cpy.Elem().Slice(0, correctLen).Interface().([]T)
	}

Proposal

Refactor that package to not use generics.

[Petrie]

You can assign this to me, thanks @MrAlias

[pellared]

nit: Shouldn't the name be changed to

The otel package implicitly requires Go >= 1.18

or

The otel package implicitly requires Go > 1.17

?

[ash2k]

Any explanation why not? Just curious.

I'm looking at some code that uses atomic.Value+type casts. It could use atomic.Pointer (added in Go 1.19) instead to avoid type casts, be more readable and type safe. If not, would be good to at document the decision somewhere in contributor docs.