Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Reader.Collect Signature. #3732

Merged
merged 7 commits into from
Feb 21, 2023

Conversation

MadVikingGod
Copy link
Contributor

This change only modifies the signature of the Collect method to enable future memory reuse. It is part of the solution to #3047.

This does not include changes to the rest of the pipeline to reduce the review surface area.

This DOES NOT make the SDK reuse memory, but it does enable it to be added.
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #3732 (4ad6f2d) into main (c5c3c95) will increase coverage by 0.0%.
The diff coverage is 95.8%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3732   +/-   ##
=====================================
  Coverage   81.6%   81.6%           
=====================================
  Files        166     166           
  Lines      12432   12445   +13     
=====================================
+ Hits       10154   10167   +13     
  Misses      2063    2063           
  Partials     215     215           
Impacted Files Coverage Δ
sdk/metric/reader.go 100.0% <ø> (ø)
sdk/metric/manual_reader.go 85.1% <90.0%> (+0.5%) ⬆️
exporters/prometheus/exporter.go 83.5% <100.0%> (+0.1%) ⬆️
sdk/metric/periodic_reader.go 91.6% <100.0%> (+0.3%) ⬆️

CHANGELOG.md Outdated Show resolved Hide resolved
sdk/metric/manual_reader.go Outdated Show resolved Hide resolved
sdk/metric/manual_reader.go Outdated Show resolved Hide resolved
sdk/metric/manual_reader.go Outdated Show resolved Hide resolved
sdk/metric/manual_reader.go Outdated Show resolved Hide resolved
sdk/metric/periodic_reader.go Outdated Show resolved Hide resolved
sdk/metric/periodic_reader.go Outdated Show resolved Hide resolved
sdk/metric/periodic_reader.go Outdated Show resolved Hide resolved
sdk/metric/periodic_reader.go Show resolved Hide resolved
sdk/metric/reader.go Outdated Show resolved Hide resolved
sdk/metric/manual_reader.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants