Do not wrap error if multierror does not have one. #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3772 +/- ##
=====================================
Coverage 81.6% 81.7%
=====================================
Files 167 167
Lines 12459 12462 +3
=====================================
+ Hits 10179 10186 +7
+ Misses 2065 2061 -4
Partials 215 215
|
dashpole
approved these changes
Feb 24, 2023
|
I prefer this approach |
hanyuancheung
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3698
This is a potential solution to #3698. The problem is there are two places where we don't provide a wrapped error when creating a
multierror. This just omits wrapping an error in cases where there isn't one to wrap.An alternative solution is to provide an error in all uses of
multierror.