Fix incorrect "all" and "resource" definition for Schema File #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
tigrannajaryan
added
the
Skip Changelog
|
I think this does not require a change log since it is a bug fix, but let me know if you think otherwise. |
MrAlias
approved these changes
Feb 24, 2023
Can you add an entry in the |
tigrannajaryan
force-pushed
the
feature/tigran/fixschemafile
branch
from
3e8767d
to
d05d9da
Compare
Done. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3777 +/- ##
=======================================
- Coverage 81.7% 81.7% -0.1%
=======================================
Files 167 167
Lines 12462 12453 -9
=======================================
- Hits 10184 10175 -9
Misses 2063 2063
Partials 215 215
|
Aneurysm9
approved these changes
Feb 24, 2023
Aneurysm9
removed
the
Skip Changelog
|
OK to merge this? |
I think this meets the repo standard to wait a full 24 hours. Is there a reason to expedite? Are we trying to push a build tools fix today? |
hanyuancheung
approved these changes
Feb 27, 2023
The "all" and "resource" sections had incorrect definitions of "attribute_rename" transform. It was missing the subkey "attribute_map". This is a bug fix and makes the implementation compliant with the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/schemas/file_format_v1.1.0.md#resources-section Related issue: open-telemetry/opentelemetry-specification#3245
tigrannajaryan
force-pushed
the
feature/tigran/fixschemafile
branch
from
5a3bf27
to
9a5f49f
Compare
|
Rebased and conflict resolved. I think this is ready to be merged. |
tigrannajaryan
added a commit
to tigrannajaryan/build-tools
that referenced
this pull request
Feb 27, 2023
Pinned to specific commit 071d3173944553bed7d05057ecccb177d307978b of https://github.com/open-telemetry/opentelemetry-go to update the schema check tool to include the bug fix open-telemetry/opentelemetry-go#3777 (Fix incorrect "all" and "resource" definition for Schema File).
tigrannajaryan
added a commit
to open-telemetry/build-tools
that referenced
this pull request
Feb 27, 2023
Pinned to specific commit 071d3173944553bed7d05057ecccb177d307978b of https://github.com/open-telemetry/opentelemetry-go to update the schema check tool to include the bug fix open-telemetry/opentelemetry-go#3777 (Fix incorrect "all" and "resource" definition for Schema File).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "all" and "resource" sections had incorrect definitions of "attribute_rename" transform. It was missing the subkey "attribute_map".
This is a bug fix and makes the implementation compliant with the spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/schemas/file_format_v1.1.0.md#resources-section
Related issue: open-telemetry/opentelemetry-specification#3245