Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement concurrent processing in BatchSpanProcessor #4354

Closed
pellared opened this issue Jul 24, 2023 · 2 comments
Closed

Reimplement concurrent processing in BatchSpanProcessor #4354

pellared opened this issue Jul 24, 2023 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@pellared
Copy link
Member

It would be a lot better to e.g. wait for exportSpans done during shutdown (and return the error), but this would need major reimplementation of the whole processing logic.

The processing logic may be implemented e.g. similarly to PeriodicReader.

Originally posted by @pellared in #4353 (comment)
@pellared pellared mentioned this issue Jul 24, 2023
Merged
@MrAlias
Copy link
Contributor

MrAlias commented Jul 24, 2023

This might be a duplicate of #1178

@pellared
Copy link
Member Author

This might be a duplicate of #1178

I agree. Closing.

@pellared pellared closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2023
@pellared pellared added the duplicate This issue or pull request already exists label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pellared @MrAlias