Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the StackDriver trace exporter #452

Merged
merged 4 commits into from
Mar 7, 2020
Merged

Remove the StackDriver trace exporter #452

merged 4 commits into from
Mar 7, 2020
+0 −1,494

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 29, 2020 •
edited
Loading

Vendor exporters needed to be hosted outside this codebase.

Additionally, remove the http-stackdriver example.

Resolves #447

Resolves #449

Remove the StackDriver trace exporter
cd19892 
Vendor exporters needed to be hosted outside this codebase.

Additionally, remove the http-stackdriver example.

Resolves #447

Partially addresses #449
@lizthegrey
Copy link
Member

Please don't do this until @ymotongpoo has found a home elsewhere for it so we can redirect appropriately.

@ymotongpoo
Copy link
Contributor

Thank you for the notification. @rghetia and I had a sync and still finding a repo to move it. If this is in a hurry, I can extract the Stackdriver codes out to my personal repos tentatively and do other process later on all on our end.

@rghetia What do you think about it?

@rghetia
Copy link
Contributor

rghetia commented Jan 30, 2020

Thank you for the notification. @rghetia and I had a sync and still finding a repo to move it. If this is in a hurry, I can extract the Stackdriver codes out to my personal repos tentatively and do other process later on all on our end.

@rghetia What do you think about it?

We should finalize the new repo by next week for stackdriver exporter. I think we can wait until then.

@MrAlias MrAlias mentioned this pull request Feb 3, 2020
Closed
@paivagustavo paivagustavo added exporters area:trace Part of OpenTelemetry tracing labels Feb 11, 2020
@lizthegrey
Copy link
Member

Thank you for the notification. @rghetia and I had a sync and still finding a repo to move it. If this is in a hurry, I can extract the Stackdriver codes out to my personal repos tentatively and do other process later on all on our end.
@rghetia What do you think about it?

We should finalize the new repo by next week for stackdriver exporter. I think we can wait until then.

What's the status of this, @rghetia and @ymotongpoo?

@rghetia
Copy link
Contributor

rghetia commented Mar 6, 2020

What's the status of this, @rghetia and @ymotongpoo?
GoogleCloudPlatform/opentelemetry-operations-go#2 - Pending approval

@rghetia
Copy link
Contributor

rghetia commented Mar 7, 2020

What's the status of this, @rghetia and @ymotongpoo?
GoogleCloudPlatform/opentelemetry-operations-go#2 - Pending approval

It is merged. Now available at https://github.com/GoogleCloudPlatform/opentelemetry-operations-go

paivagustavo
paivagustavo approved these changes Mar 7, 2020
View reviewed changes
Copy link
Member

@paivagustavo paivagustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can agree to remove the hold on this, right?

@paivagustavo paivagustavo removed the hold label Mar 7, 2020
@rghetia rghetia merged commit 9459629 into open-telemetry:master Mar 7, 2020
@MrAlias MrAlias deleted the remove-sd-trace-exporter branch March 7, 2020 01:54
MikeGoldsmith pushed a commit to MikeGoldsmith/opentelemetry-go that referenced this pull request Mar 13, 2020
@MrAlias @rghetia @MikeGoldsmith
Remove the StackDriver trace exporter (open-telemetry#452)
d205fb6 
Vendor exporters needed to be hosted outside this codebase.

Additionally, remove the http-stackdriver example.

Resolves open-telemetry#447

Partially addresses open-telemetry#449

Co-authored-by: Rahul Patel <rahulpa@google.com>
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krnowak krnowak

@lizthegrey lizthegrey

@jmacd jmacd

@paivagustavo paivagustavo

@iredelmeier iredelmeier

@rghetia rghetia

@tedsuo tedsuo

Assignees
No one assigned
Labels
area:trace Part of OpenTelemetry tracing
Projects
None yet
Milestone
untracked
Development

Successfully merging this pull request may close these issues.

Remove Vendor Exporters Data Race in Testing
8 participants
@MrAlias @lizthegrey @ymotongpoo @rghetia @krnowak @jmacd @paivagustavo @pellared