Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WithEndpointURL option to OTLP over HTTP exporters #4808

Merged
merged 10 commits into from Jan 19, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Jan 2, 2024

Closes #3730.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8778c38) 82.3% compared to head (50da281) 82.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4808   +/-   ##
=====================================
  Coverage   82.3%   82.3%           
=====================================
  Files        226     226           
  Lines      18421   18481   +60     
=====================================
+ Hits       15164   15224   +60     
  Misses      2971    2971           
  Partials     286     286           
Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetricgrpc/config.go 43.8% <100.0%> (+2.0%) ⬆️
...tlpmetric/otlpmetricgrpc/internal/oconf/options.go 88.4% <100.0%> (+0.9%) ⬆️
exporters/otlp/otlpmetric/otlpmetrichttp/config.go 86.6% <100.0%> (+0.9%) ⬆️
...tlpmetric/otlpmetrichttp/internal/oconf/options.go 91.4% <100.0%> (+0.7%) ⬆️
...trace/otlptracegrpc/internal/otlpconfig/options.go 94.0% <100.0%> (+0.5%) ⬆️
exporters/otlp/otlptrace/otlptracegrpc/options.go 77.3% <100.0%> (+0.8%) ⬆️
...trace/otlptracehttp/internal/otlpconfig/options.go 90.6% <100.0%> (+0.8%) ⬆️
exporters/otlp/otlptrace/otlptracehttp/options.go 100.0% <100.0%> (ø)

@pellared pellared dismissed their stale review January 3, 2024 13:36

Non-blocking comments

@pellared

This comment was marked as resolved.

@pellared pellared changed the title Introduce WithEndpointURL option to OTLP exporters Add WithEndpointURL option to OTLP over HTTP exporters Jan 19, 2024
@pellared pellared merged commit 33f5cf4 into open-telemetry:main Jan 19, 2024
25 checks passed
m-posluszny pushed a commit to m-posluszny/opentelemetry-go that referenced this pull request Jan 19, 2024
@MrAlias MrAlias added this to the v1.23.0 milestone Feb 5, 2024
@MrAlias MrAlias mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency between X_ENDPOINT and WithEndpoint
5 participants