Replace ErrNoLastValue and ErrEmptyDataSet by ErrNoData #557
+213
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle ForEach returning an error
evantorrie
requested review from
jmacd,
krnowak,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
|
closing and reopening to trigger the build. |
rghetia
approved these changes
Mar 16, 2020
jmacd
approved these changes
Mar 16, 2020
MrAlias
approved these changes
Mar 16, 2020
This was referenced Mar 17, 2020
|
Bam! Thank you @evantorrie! |
oncilla
added a commit
to oncilla/opentelemetry-go
that referenced
this pull request
Apr 6, 2020
This PR modifies prometheus.Collect to reflect the change introduced by open-telemetry#557. The `export{Counter,Histogram,LastValue,Summary}` methods now all return an error instead of calling the error callback directly. The callback is now only called on the returned error from `ForEach`. fixes open-telemetry#563
rghetia
added a commit
that referenced
this pull request
Apr 7, 2020
This PR modifies prometheus.Collect to reflect the change introduced by #557. The `export{Counter,Histogram,LastValue,Summary}` methods now all return an error instead of calling the error callback directly. The callback is now only called on the returned error from `ForEach`. fixes #563 Co-authored-by: Rahul Patel <rahulpa@google.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this comment in issue #346, this PR replaces
ErrNoLastValueandErrEmptyDataSetby a singleErrNoData.The checkpoint
ForEach()interface is changed to both take a function which returns an error, and to return an error itself.ErrNoDatais treated silently byForEach(), whereas other errors are immediately returned to the caller.Note that
ErrNonMonotoneInputis currently unused by the current aggregators and is removed (it may need to make a reappearance).