Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts for releasing. #576

Merged
merged 3 commits into from
Mar 21, 2020
Merged

Scripts for releasing. #576

merged 3 commits into from
Mar 21, 2020

Conversation

rghetia
Copy link
Contributor

@rghetia rghetia commented Mar 20, 2020

It is not completely automated but two scripts allows to update go.mod and create tag for root/submodules.

  • pre-release.sh - This updates go.mod
  • tag.sh - Creates a new tag for root module and sub-modules.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Minor fixes need though.

@rghetia
Copy link
Contributor Author

rghetia commented Mar 20, 2020

@MrAlias PTAL.

@jmacd jmacd merged commit a15e507 into open-telemetry:master Mar 21, 2020
PACKAGE_DIRS=$(find . -mindepth 2 -type f -name 'go.mod' -exec dirname {} \; | egrep -v 'tools' | sed 's/^\.\///' | sort)

# Create tag for root module
git tag -a "${TAG}" -m "Version ${TAG}" ${COMMIT_HASH}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, you may want to sign the tag with -s

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened #589 to update the script.


# Create tag for submodules
for dir in $PACKAGE_DIRS; do
git tag -a "${dir}/${TAG}" -m "Version ${dir}/${TAG}" ${COMMIT_HASH}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto here.

@lizthegrey
Copy link
Member

Copy link
Contributor Author

@rghetia rghetia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can delete https://github.com/open-telemetry/opentelemetry-go/blob/master/tag_latest_modules.sh now right?

yes. Will. take care of it in #589.

@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document/automate release process
5 participants