-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts for releasing. #576
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Minor fixes need though.
@MrAlias PTAL. |
PACKAGE_DIRS=$(find . -mindepth 2 -type f -name 'go.mod' -exec dirname {} \; | egrep -v 'tools' | sed 's/^\.\///' | sort) | ||
|
||
# Create tag for root module | ||
git tag -a "${TAG}" -m "Version ${TAG}" ${COMMIT_HASH} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future, you may want to sign the tag with -s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened #589 to update the script.
|
||
# Create tag for submodules | ||
for dir in $PACKAGE_DIRS; do | ||
git tag -a "${dir}/${TAG}" -m "Version ${dir}/${TAG}" ${COMMIT_HASH} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto here.
We can delete https://github.com/open-telemetry/opentelemetry-go/blob/master/tag_latest_modules.sh now right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can delete https://github.com/open-telemetry/opentelemetry-go/blob/master/tag_latest_modules.sh now right?
yes. Will. take care of it in #589.
It is not completely automated but two scripts allows to update go.mod and create tag for root/submodules.