From ca315c6f6bf8f5cd68971907b324983717488b69 Mon Sep 17 00:00:00 2001
From: Andrei Matei <andrei@cockroachlabs.com>
Date: Sun, 19 Sep 2021 13:25:26 -0400
Subject: [PATCH] zipkin: remove no-op WithSDKOptions

This method did not have any effect. had been used back
when exporters were providing utility methods for setting up full
pipelines. These utilities went away in
4883cb119d59de101dba898fd02604b989734089.
---
 CHANGELOG.md               | 1 +
 example/zipkin/main.go     | 1 -
 exporters/zipkin/zipkin.go | 8 --------
 3 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index bd906ea7ca5..f4c669edff3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ### Removed
 
+- Removed the zipkin.WithSDKOptions function. It already didn't have any effect (#2248).
 - Removed the deprecated package `go.opentelemetry.io/otel/oteltest`. (#2234)
 - Removed the deprecated package `go.opentelemetry.io/otel/bridge/opencensus/utils`. (#2233)
 - Removed deprecated functions, types, and methods from `go.opentelemetry.io/otel/attribute` package.
diff --git a/example/zipkin/main.go b/example/zipkin/main.go
index 08689854d93..578255c4a39 100644
--- a/example/zipkin/main.go
+++ b/example/zipkin/main.go
@@ -43,7 +43,6 @@ func initTracer(url string) func() {
 	exporter, err := zipkin.New(
 		url,
 		zipkin.WithLogger(logger),
-		zipkin.WithSDKOptions(sdktrace.WithSampler(sdktrace.AlwaysSample())),
 	)
 	if err != nil {
 		log.Fatal(err)
diff --git a/exporters/zipkin/zipkin.go b/exporters/zipkin/zipkin.go
index 8de40472224..2d45301dd79 100644
--- a/exporters/zipkin/zipkin.go
+++ b/exporters/zipkin/zipkin.go
@@ -49,7 +49,6 @@ var (
 type config struct {
 	client *http.Client
 	logger *log.Logger
-	tpOpts []sdktrace.TracerProviderOption
 }
 
 // Option defines a function that configures the exporter.
@@ -77,13 +76,6 @@ func WithClient(client *http.Client) Option {
 	})
 }
 
-// WithSDKOptions configures options passed to the created TracerProvider.
-func WithSDKOptions(tpOpts ...sdktrace.TracerProviderOption) Option {
-	return optionFunc(func(cfg *config) {
-		cfg.tpOpts = tpOpts
-	})
-}
-
 // New creates a new Zipkin exporter.
 func New(collectorURL string, opts ...Option) (*Exporter, error) {
 	if collectorURL == "" {