Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec compliance] Metrics SDK does not fail on duplicate name/different instrument metrics. #3809

Closed
jsuereth opened this issue Oct 31, 2021 · 2 comments
Labels
Feature Request Suggest an idea for this project metrics SDK

Comments

@jsuereth
Copy link
Contributor

Currently, the metric storage component does not fail if in the current scenario:

  • There are two different instruments (e.g. Counter + Histogram) with the same name on the same meter
  • A user provided View configuration renames the Counter to another name with no conflict.

This should fail, according to the specification.

@jack-berg
Copy link
Member

There are two different instruments (e.g. Counter + Histogram) with the same name on the same meter

@jsuereth I believe this is no longer possible now that MetricDescriptor#isCompatible(MetricDescriptor) checks that the instruments are of the same type. The user should get a compatibility warning log if they try to do this.

@jack-berg
Copy link
Member

Closing because the spec has clarified the behavior in the presence of identity conflicts. This was implemented in #4222.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project metrics SDK
Projects
No open projects
Metrics Stability
SDK Stability
Development

No branches or pull requests

2 participants