Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Aggregator.diff, no need to support Cumulative -> Delta based on the metrics SIG. #3883

Closed
bogdandrutu opened this issue Nov 16, 2021 · 4 comments
Assignees
Labels
Feature Request Suggest an idea for this project

Comments

@bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu added the Feature Request Suggest an idea for this project label Nov 16, 2021
@jack-berg
Copy link
Member

Aggregator.diff is used to support delta export of asynchronous instruments, which are assumed to be cumulative. If we remove this method, than you can only export asynchronous instruments as cumualtive.

@bogdandrutu
Copy link
Member Author

The SDK should not do this because may not be able to do it for all the Aggregators so if any of exporter needs this they can implement it. See open-telemetry/opentelemetry-go#2350

@jack-berg
Copy link
Member

exporter needs this they can implement it.

True. Right now Aggregator is an internal class because you can't define your own Aggregation. So I think its fine now, but something needed if we want to make it possible to define custom Aggregations.

@jack-berg
Copy link
Member

Closing because: 1. Cumulative -> delta is necessary in the SDK for delta export of async counter and async up down counter. 2. Aggregator is an internal implementation detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

3 participants