From d87300db28b116ef16c93bdaca740a0f67e957e0 Mon Sep 17 00:00:00 2001 From: Gerhard Stoebich <18708370+Flarna@users.noreply.github.com> Date: Fri, 28 May 2021 23:55:40 +0200 Subject: [PATCH 1/2] chore: enable typescript 4.3 noImplicitOverride option Enable typescript 4.3 feature noImplicitOverride to improve code quality. Besides that some other dev-dependencies are updated. --- package.json | 20 ++++++++++---------- test/api/api.test.ts | 4 ++-- tsconfig.json | 1 + 3 files changed, 13 insertions(+), 12 deletions(-) diff --git a/package.json b/package.json index 8bf99ab6..a563e499 100644 --- a/package.json +++ b/package.json @@ -56,16 +56,16 @@ }, "devDependencies": { "@types/mocha": "8.2.2", - "@types/node": "14.14.42", - "@types/sinon": "10.0.0", + "@types/node": "14.17.1", + "@types/sinon": "10.0.2", "@types/webpack-env": "1.16.0", - "@typescript-eslint/eslint-plugin": "4.22.0", - "@typescript-eslint/parser": "4.22.0", - "codecov": "3.8.1", - "eslint": "7.25.0", + "@typescript-eslint/eslint-plugin": "4.26.0", + "@typescript-eslint/parser": "4.26.0", + "codecov": "3.8.2", + "eslint": "7.28.0", "eslint-plugin-header": "3.1.1", - "eslint-plugin-import": "2.22.1", - "gh-pages": "3.1.0", + "eslint-plugin-import": "2.23.4", + "gh-pages": "3.2.0", "gts": "3.1.0", "istanbul-instrumenter-loader": "3.0.1", "karma": "5.2.3", @@ -78,11 +78,11 @@ "linkinator": "2.13.6", "mocha": "7.2.0", "nyc": "15.1.0", - "sinon": "10.0.0", + "sinon": "11.1.1", "ts-loader": "8.2.0", "ts-mocha": "8.0.0", "typedoc": "0.20.36", - "typescript": "4.2.4", + "typescript": "4.3.2", "webpack": "4.46.0" } } diff --git a/test/api/api.test.ts b/test/api/api.test.ts index 7f6bce84..f5a86cbc 100644 --- a/test/api/api.test.ts +++ b/test/api/api.test.ts @@ -94,13 +94,13 @@ describe('API', () => { }); class TestTracer extends NoopTracer { - startSpan(name: string, options?: SpanOptions): Span { + override startSpan(name: string, options?: SpanOptions): Span { return dummySpan; } } class TestTracerProvider extends NoopTracerProvider { - getTracer(_name: string, version?: string) { + override getTracer(_name: string, version?: string) { return new TestTracer(); } } diff --git a/tsconfig.json b/tsconfig.json index 174714d7..16e952fa 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -10,6 +10,7 @@ "noFallthroughCasesInSwitch": true, "noImplicitReturns": true, "noUnusedLocals": true, + "noImplicitOverride": true, "outDir": "build", "pretty": true, "rootDir": ".", From 79c3e0b59117fe03eecad25d4fc4148c082c002d Mon Sep 17 00:00:00 2001 From: Gerhard Stoebich <18708370+Flarna@users.noreply.github.com> Date: Sat, 5 Jun 2021 20:10:29 +0200 Subject: [PATCH 2/2] update typedoc for ts 4.3 support --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index a563e499..3880ebfd 100644 --- a/package.json +++ b/package.json @@ -81,7 +81,7 @@ "sinon": "11.1.1", "ts-loader": "8.2.0", "ts-mocha": "8.0.0", - "typedoc": "0.20.36", + "typedoc": "0.21.0-beta.1", "typescript": "4.3.2", "webpack": "4.46.0" }