From 68e54490b207980b080d6642be48e81d17659cc7 Mon Sep 17 00:00:00 2001 From: Ofer Adelstein <12687466+CptSchnitz@users.noreply.github.com> Date: Mon, 26 Jul 2021 20:50:37 +0300 Subject: [PATCH] style: use single quotes everywhere and add a rule to eslint (#583) --- eslint.config.js | 1 + metapackages/auto-instrumentations-web/README.md | 2 +- .../node/opentelemetry-instrumentation-ioredis/README.md | 6 +++--- .../opentelemetry-propagator-grpc-census-binary/README.md | 2 +- scripts/version-update.js | 2 +- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/eslint.config.js b/eslint.config.js index 7c1a2ca886..6ac74884ca 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -11,6 +11,7 @@ module.exports = { "project": "./tsconfig.json" }, rules: { + "quotes": [2, "single", { "avoidEscape": true }], "@typescript-eslint/no-this-alias": "off", "eqeqeq": "off", "prefer-rest-params": "off", diff --git a/metapackages/auto-instrumentations-web/README.md b/metapackages/auto-instrumentations-web/README.md index f76cf87c50..da8dd4e07f 100644 --- a/metapackages/auto-instrumentations-web/README.md +++ b/metapackages/auto-instrumentations-web/README.md @@ -37,7 +37,7 @@ registerInstrumentations({ instrumentations: [ getWebAutoInstrumentations({ // load custom configuration for xml-http-request instrumentation - "@opentelemetry/instrumentation-xml-http-request": { + '@opentelemetry/instrumentation-xml-http-request': { clearTimingResources: true, }, }), diff --git a/plugins/node/opentelemetry-instrumentation-ioredis/README.md b/plugins/node/opentelemetry-instrumentation-ioredis/README.md index 1c8eaa27d0..6cad71ec4d 100644 --- a/plugins/node/opentelemetry-instrumentation-ioredis/README.md +++ b/plugins/node/opentelemetry-instrumentation-ioredis/README.md @@ -25,11 +25,11 @@ npm install --save @opentelemetry/instrumentation-ioredis To load a specific instrumentation (**ioredis** in this case), specify it in the registerInstrumentations's configuration ```javascript -const { NodeTracerProvider } = require("@opentelemetry/node"); +const { NodeTracerProvider } = require('@opentelemetry/node'); const { IORedisInstrumentation, -} = require("@opentelemetry/instrumentation-ioredis"); -const { registerInstrumentations } = require("@opentelemetry/instrumentation"); +} = require('@opentelemetry/instrumentation-ioredis'); +const { registerInstrumentations } = require('@opentelemetry/instrumentation'); const provider = new NodeTracerProvider(); provider.register(); diff --git a/propagators/opentelemetry-propagator-grpc-census-binary/README.md b/propagators/opentelemetry-propagator-grpc-census-binary/README.md index 37d3f81359..b270480922 100644 --- a/propagators/opentelemetry-propagator-grpc-census-binary/README.md +++ b/propagators/opentelemetry-propagator-grpc-census-binary/README.md @@ -16,7 +16,7 @@ Example of usage: ```javascript const { NodeTracerProvider } = require('@opentelemetry/node'); -const { GrpcCensusPropagator } = require("@opentelemetry/propagator-grpc-census-binary"); +const { GrpcCensusPropagator } = require('@opentelemetry/propagator-grpc-census-binary'); const { registerInstrumentations } = require('@opentelemetry/instrumentation'); const { GrpcInstrumentation } = require('opentelemetry/instrumentation-grpc'); diff --git a/scripts/version-update.js b/scripts/version-update.js index 992f8f4ba1..77a4969bca 100644 --- a/scripts/version-update.js +++ b/scripts/version-update.js @@ -43,6 +43,6 @@ const content = `/* export const VERSION = '${pjson.version}'; `; -const fileUrl = path.join(appRoot, "src", "version.ts") +const fileUrl = path.join(appRoot, 'src', 'version.ts') fs.writeFileSync(fileUrl, content);