Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime instrumentation #1106

Open
morigs opened this issue Aug 2, 2022 · 7 comments
Open

Runtime instrumentation #1106

morigs opened this issue Aug 2, 2022 · 7 comments

Comments

@morigs
Copy link

morigs commented Aug 2, 2022

Is your instrumentation request related to a problem? Please describe

It's very useful to have metrics about platform runtime - heap status, GC metrics, event loop blocks etc...
OpenTelemetry Go provides runtime instrumentation for this.

For example, if application code behaves strangely, these metrics can understand if this because of GC lock or because of event loop block.

This instrumentation can move OTel forward to full-featured APM solution.

Is it applicable for Node or Browser or both?

Mostly Node

Do you expect this instrumentation to be commonly used?

I believe, it's very useful. prom-client includes these metrics and they're commonly used

@tomerfriedman
Copy link

tomerfriedman commented Aug 6, 2022

Going to start working on this (first contribution). Any objections?

I already implemented something like that on my own. And was thinking to put it under "packages" here. (same as host-metrics)

@vmarchaud
Copy link
Member

vmarchaud commented Aug 6, 2022

Any objections?

None, I will assign the issue to you !

And was thinking to put it under "packages" here. (same as host-metrics)

Yeah i think its the most logical place

@dyladan
Copy link
Member

dyladan commented Aug 6, 2022

Maybe this should go in the core repo? Similar to http and grpc instrumentation I think it is quite important and it is likely to get more maintainer attention there

@dyladan
Copy link
Member

dyladan commented Aug 6, 2022

Host metrics too maybe

@daniel-white
Copy link

would love to see the GC metrics, something along the lines of https://github.com/SimenB/node-prometheus-gc-stats

@LiranBri
Copy link

LiranBri commented Jan 1, 2023

+1
seeing event-loop delays is super required to be able to monitor the health of a nodejs service

@pikalovArtemN
Copy link

Add some prom-client metrics
#2136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants