Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add node:16 to the test matrix #510

Merged
merged 13 commits into from Jun 12, 2021

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented May 31, 2021

Which problem is this PR solving?

  • Add node:16 to the test matrix;
  • Add chown -R 1001:121 "/github/home/.npm" to fix the cache permissions - npm v7 does not allow root-owned files in cache;
  • Revert karma-webpack to v4 in some packages because of the peerDep conflict;
  • Fix net instrumentation test - in node v16 socket.connect is more strict with passed params;

Adds current node version(16) to the test matrix.

@rauno56 rauno56 requested a review from a team as a code owner May 31, 2021 19:06
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #510 (f996550) into main (93753ec) will decrease coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
- Coverage   95.24%   94.79%   -0.45%     
==========================================
  Files           8      152     +144     
  Lines         505     9230    +8725     
  Branches       89      918     +829     
==========================================
+ Hits          481     8750    +8269     
- Misses         24      480     +456     
Impacted Files Coverage Δ
...de/opentelemetry-instrumentation-hapi/src/types.ts 100.00% <0.00%> (ø)
...e/opentelemetry-instrumentation-mysql/src/utils.ts 100.00% <0.00%> (ø)
...propagator-aws-xray/test/AWSXRayPropagator.test.ts 100.00% <0.00%> (ø)
...metry-instrumentation-winston/test/winston.test.ts 97.87% <0.00%> (ø)
...opentelemetry-instrumentation-mongodb/src/types.ts 100.00% <0.00%> (ø)
...y-instrumentation-hapi/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...opentelemetry-instrumentation-net/test/tls.test.ts 93.24% <0.00%> (ø)
...node/opentelemetry-instrumentation-pg/src/utils.ts 97.26% <0.00%> (ø)
...ackages/opentelemetry-host-metrics/src/stats/si.ts 66.66% <0.00%> (ø)
...e/opentelemetry-instrumentation-koa/src/version.ts 100.00% <0.00%> (ø)
... and 134 more

@rauno56
Copy link
Member Author

rauno56 commented May 31, 2021

That's interesting. Does anyone have experience with the error in CI?

Since we're not caching anything yet in the node:16 runs, I assume it has to do with the underlying node container.

npm ERR! code EACCES
npm ERR! syscall mkdir
npm ERR! path /github/home/.npm/_cacache/content-v2/sha1/46/c3
npm ERR! errno -13
npm ERR! 
npm ERR! Your cache folder contains root-owned files, due to a bug in
npm ERR! previous versions of npm which has since been addressed.
npm ERR! 
npm ERR! To permanently fix this problem, please run:
npm ERR!   sudo chown -R 1001:121 "/github/home/.npm"

npm ERR! A complete log of this run can be found in:
npm ERR!     /github/home/.npm/_logs/2021-05-31T19_13_29_158Z-debug.log

@rauno56
Copy link
Member Author

rauno56 commented Jun 1, 2021

@anuraaga, I reverted karma-webpack version to 4 for packages, you've contributed. Is that alright?

@vmarchaud vmarchaud merged commit 3e519d9 into open-telemetry:main Jun 12, 2021
nata7che pushed a commit to helios/opentelemetry-js-contrib that referenced this pull request Jun 13, 2021
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
@vmarchaud vmarchaud added the enhancement New feature or request label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants