Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move api into peer dependency #522

Merged
merged 2 commits into from Jun 7, 2021
Merged

chore: move api into peer dependency #522

merged 2 commits into from Jun 7, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jun 4, 2021

No description provided.

@Flarna Flarna requested a review from a team as a code owner June 4, 2021 19:38
@codecov
Copy link

codecov bot commented Jun 4, 2021 •
edited

Codecov Report

Merging #522 (101304c) into main (5d73dc2) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   94.81%   94.75%   -0.06%     
==========================================
  Files         150      147       -3     
  Lines        9153     9045     -108     
  Branches      904      880      -24     
==========================================
- Hits         8678     8571     -107     
+ Misses        475      474       -1
Impacted Files Coverage Δ
...entation-document-load/src/enums/AttributeNames.ts
...strumentation-document-load/src/instrumentation.ts
...metry-instrumentation-document-load/src/version.ts

weyert
weyert approved these changes Jun 5, 2021
View reviewed changes
Copy link

@weyert weyert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me :)

@vmarchaud vmarchaud requested a review from a team June 5, 2021 08:21
obecny
obecny approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
+1 for adding github actions

@obecny obecny merged commit 2a30f62 into open-telemetry:main Jun 7, 2021
@dyladan dyladan added the enhancement New feature or request label Jun 9, 2021
@Flarna Flarna deleted the api-peer-dep branch June 9, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weyert weyert weyert approved these changes

@obecny obecny obecny approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Flarna @weyert @obecny @vmarchaud @dyladan