Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cassandra-driver instrumentation #538

Merged
merged 13 commits into from Jun 30, 2021

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Jun 15, 2021

Which problem is this PR solving?

Adds cassandra-driver instrumentation.

Short description of the changes

  • Instruments execute, batch, stream calls. stream span ends when all of the data has been received.
  • Added support for Cassandra docker images to test-utils.
  • Supported versions: >=4.4 <5.0

@seemk seemk requested a review from a team as a code owner June 15, 2021 11:58
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #538 (d40d19e) into main (1743b7f) will decrease coverage by 2.09%.
The diff coverage is n/a.

❗ Current head d40d19e differs from pull request most recent head 65962b2. Consider uploading reports for the commit 65962b2 to get more accurate results

@@            Coverage Diff             @@
##             main     #538      +/-   ##
==========================================
- Coverage   96.68%   94.58%   -2.10%     
==========================================
  Files          13      156     +143     
  Lines         634     9702    +9068     
  Branches      124     1003     +879     
==========================================
+ Hits          613     9177    +8564     
- Misses         21      525     +504     
Impacted Files Coverage Δ
...pentelemetry-instrumentation-pg/test/utils.test.ts 98.36% <0.00%> (ø)
...instrumentation-router/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...tor-grpc-census-binary/src/GrpcCensusPropagator.ts 97.43% <0.00%> (ø)
...instrumentation-dns/test/functionals/utils.test.ts 98.71% <0.00%> (ø)
...pentelemetry-instrumentation-knex/src/constants.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-pino/test/pino.test.ts 100.00% <0.00%> (ø)
...metry-propagator-aws-xray/src/AWSXRayPropagator.ts 100.00% <0.00%> (ø)
...metry-instrumentation-graphql/test/graphql.test.ts 100.00% <0.00%> (ø)
...ce-detector-github/src/detectors/GitHubDetector.ts 100.00% <0.00%> (ø)
...de/opentelemetry-instrumentation-hapi/src/utils.ts 100.00% <0.00%> (ø)
... and 133 more

@obecny
Copy link
Member

obecny commented Jun 28, 2021

it looks like version 3.x is still quite popular would you be able to add support for version 3 too ?

image

@seemk
Copy link
Contributor Author

seemk commented Jun 29, 2021

it looks like version 3.x is still quite popular would you be able to add support for version 3 too ?

As it's already 3 years old and gradually phased out, perhaps it would make sense to add it once someone explicitly requests it?

By the way, a CI job is stuck at Starting workflow run for node 14, is it possible to restart it? Nvm, pushed a commit

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtnm

@dyladan dyladan added the enhancement New feature or request label Jun 30, 2021
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with seemk, there is no urgent need to support old versions unless someone requests it.

Please fix the conflicts and this can be merged

@dyladan dyladan requested a review from johnbley June 30, 2021 14:34
@dyladan dyladan merged commit bbf298d into open-telemetry:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants