chore: enable typescript 4.3 option noImplicitOverride #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable typescript 4.3 feature noImplicitOverride to improve code quality. Adapt code to compile by adding override keyword or avoid overriding. Update some dev-dependencies and correct some lint warnings. Configure tsx files to use LF instead CRLF to stay in sync with ts files.
Codecov Report
@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 94.72% 94.77% +0.05%
==========================================
Files 174 179 +5
Lines 10797 10921 +124
Branches 1057 1083 +26
==========================================
+ Hits 10227 10350 +123
- Misses 570 571 +1
|
Flarna
commented
Jun 26, 2021
plugins/node/opentelemetry-instrumentation-aws-lambda/src/instrumentation.ts
Show resolved
Hide resolved
dyladan
approved these changes
Jun 28, 2021
blumamir
approved these changes
Jun 30, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable typescript 4.3 feature
noImplicitOverrideto improve code quality.Adapt code to compile by adding override keyword or avoid overriding.
Update some dev-dependencies and correct some lint warnings.
Configure tsx files to use LF instead CRLF to stay in sync with ts files.
Refs: open-telemetry/opentelemetry-js#2241