feat: Add NestJS instrumentation #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauno56
force-pushed
the
feat/nestjs-core-instrumentation
branch
from
3e3ad83
to
e407e1c
Compare
rauno56
force-pushed
the
feat/nestjs-core-instrumentation
branch
from
e407e1c
to
189f896
Compare
vmarchaud
reviewed
Jul 28, 2021
plugins/node/opentelemetry-instrumentation-nestjs-core/src/version.ts
Outdated
Show resolved
Hide resolved
In v8 there's a deprecation warning for `listenAsync`.
…trib into feat/nestjs-core-instrumentation
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
==========================================
- Coverage 96.68% 94.03% -2.65%
==========================================
Files 13 20 +7
Lines 634 906 +272
Branches 124 161 +37
==========================================
+ Hits 613 852 +239
- Misses 21 54 +33
|
|
Note to myself: When that gets merged, I need to update versions again. |
dyladan
reviewed
Jul 28, 2021
plugins/node/opentelemetry-instrumentation-nestjs-core/package.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan
approved these changes
Jul 28, 2021
plugins/node/opentelemetry-instrumentation-nestjs-core/src/instrumentation.ts
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-nestjs-core/src/utils.ts
Outdated
Show resolved
Hide resolved
Flarna
reviewed
Jul 28, 2021
plugins/node/opentelemetry-instrumentation-nestjs-core/package.json
Outdated
Show resolved
Hide resolved
Flarna
reviewed
Jul 28, 2021
plugins/node/opentelemetry-instrumentation-nestjs-core/package.json
Outdated
Show resolved
Hide resolved
Flarna
reviewed
Jul 28, 2021
Flarna
reviewed
Jul 28, 2021
plugins/node/opentelemetry-instrumentation-nestjs-core/src/index.ts
Outdated
Show resolved
Hide resolved
It was left there from an earlier verison which used it.
…trib into feat/nestjs-core-instrumentation
johnbley
approved these changes
Jul 29, 2021
plugins/node/opentelemetry-instrumentation-nestjs-core/test/index.test.ts
Show resolved
Hide resolved
|
Can you please add yourself to |
…trib into feat/nestjs-core-instrumentation
rauno56
force-pushed
the
feat/nestjs-core-instrumentation
branch
from
a2200e5
to
41cbf63
Compare
MSNev
approved these changes
Aug 12, 2021
…trib into feat/nestjs-core-instrumentation
dyladan
reviewed
Aug 18, 2021
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds a auto-instrumentation for NestJS. The current solution is still minimal and only traces controllers and the whole request context. Latter also includes guard, interception and pipe execution, which are currently not traced but can be added later without breaking what's already there.