Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unneeded ts-node dev-dependency #554

Merged
merged 3 commits into from Jul 1, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Jun 30, 2021

remove ts-node as dev-dependency as it seems it's not needed

@Flarna Flarna requested a review from a team as a code owner June 30, 2021 18:51
@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #554 (fb9b9c0) into main (53d7288) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   94.80%   94.75%   -0.06%     
==========================================
  Files         160      169       +9     
  Lines       10381    10699     +318     
  Branches     1026     1066      +40     
==========================================
+ Hits         9842    10138     +296     
- Misses        539      561      +22     
Impacted Files Coverage Δ
...ges/opentelemetry-host-metrics/src/stats/common.ts 100.00% <0.00%> (ø)
...apackages/auto-instrumentations-web/src/version.ts 0.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/version.ts 100.00% <0.00%> (ø)
...ges/opentelemetry-host-metrics/test/metric.test.ts 96.89% <0.00%> (ø)
...ackages/opentelemetry-host-metrics/src/stats/si.ts 66.66% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/metric.ts 100.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/enum.ts 100.00% <0.00%> (ø)
...etapackages/auto-instrumentations-web/src/utils.ts 95.83% <0.00%> (ø)
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 57.57% <0.00%> (ø)

@Flarna Flarna added the dependencies Pull requests that update a dependency file label Jun 30, 2021
@Flarna Flarna changed the title chore: remove unneeded dev-deps chore: remove unneeded ts-node dev-dependency Jun 30, 2021
@obecny obecny added the internal label Jul 1, 2021
@obecny obecny merged commit ad6e58e into open-telemetry:main Jul 1, 2021
@Flarna Flarna deleted the rm-deps branch July 1, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants