Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: aligning target for esm build with core repo #557

Merged
merged 4 commits into from Jul 2, 2021
Merged

chore: aligning target for esm build with core repo #557

merged 4 commits into from Jul 2, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Jul 1, 2021 •
edited

Which problem is this PR solving?

  • core repo has target for esm build as es5, whereas contrib es6 this is causing problem with IE11 when importing modules with webpack I'm getting syntax error, besides that we should be using the same target in both repos

@obecny obecny added the bug Something isn't working label Jul 1, 2021
@obecny obecny self-assigned this Jul 1, 2021
@obecny obecny requested a review from a team as a code owner July 1, 2021 19:28
@codecov
Copy link

codecov bot commented Jul 1, 2021 •
edited

Codecov Report

Merging #557 (e5b9134) into main (ad6e58e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #557   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         169      169           
  Lines       10699    10699           
  Branches     1066     1066           
=======================================
  Hits        10138    10138           
  Misses        561      561

@obecny obecny changed the title chore: aligning target for esm build on with core repo chore: aligning target for esm build with core repo Jul 2, 2021
@vmarchaud vmarchaud merged commit 526f948 into open-telemetry:main Jul 2, 2021
@obecny obecny deleted the esm branch July 2, 2021 14:29
@mdbudnick mdbudnick mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarchaud vmarchaud vmarchaud approved these changes

@Flarna Flarna Flarna approved these changes

Assignees

@obecny obecny

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@obecny @vmarchaud @Flarna