Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation-hapi): change root span name to route name #571

Merged
merged 3 commits into from Jul 17, 2021

Conversation

CptSchnitz
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • root span is renamed once the route information is known (name is like in the express instrumentation)
  • http.route attribute is also set on the root span
  • added unit test to cover this

@CptSchnitz CptSchnitz requested a review from a team as a code owner July 13, 2021 17:43
@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #571 (b95a87a) into main (9668b42) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head b95a87a differs from pull request most recent head 478b3e6. Consider uploading reports for the commit 478b3e6 to get more accurate results

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
- Coverage   94.77%   94.67%   -0.11%     
==========================================
  Files         179      166      -13     
  Lines       10946    10342     -604     
  Branches     1086      964     -122     
==========================================
- Hits        10374     9791     -583     
+ Misses        572      551      -21     
Impacted Files Coverage Δ
...de/opentelemetry-instrumentation-hapi/src/utils.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-hapi/test/hapi.test.ts 100.00% <0.00%> (ø)
...entation-document-load/src/enums/AttributeNames.ts
...umentation-user-interaction/src/instrumentation.ts
...lemetry-instrumentation-document-load/src/utils.ts
...etry-plugin-react-load/src/enums/AttributeNames.ts
...apackages/auto-instrumentations-web/src/version.ts
...etapackages/auto-instrumentations-web/src/utils.ts
...lugin-react-load/src/BaseOpenTelemetryComponent.ts
...metry-instrumentation-document-load/src/version.ts
... and 6 more

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@dyladan dyladan added the enhancement New feature or request label Jul 13, 2021
@CptSchnitz
Copy link
Contributor Author

@dyladan happy to help ☺️.
As long as there are issues I'll try to help.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@klaemo
Copy link

klaemo commented Jul 17, 2021

Thank you so much for working on this @CptSchnitz ☺️🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use route as root span name in hapi instrumentation
7 participants